Initiate reconnect when server stops sending data #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is a network connectivity issue with the server, we could end up waiting for a TCP timeout before detecting that our pings are not being responded to. Instead, let's keep track of the last time the server sent us a message and initiate a reconnect if we haven't received anything within a sessionTimeout interval.
jahqueel
force-pushed
the
session-timeout
branch
from
8be790e to
a21d322
Compare
|
This may mitigate #16 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the server stops responding to pings (or anything else) while
CONNECTED, the library doesn't notice until a TCP timeout occurs, which takes much longer than thesessionTimeout. It's possible to reproduce this via iptables:The java library tracks when it last received a message from the server, and disconnects when it's been longer than the session timeout.
This patch replicates that functionality.